Delete specific row from File-CodePudding

I have this little project in C# where I am manipulating with files. Now my task is that I have to delete specific rows from files.

For example my file looks like this:

1-this is the first line
2-this is the second line
3-this is the third line
4-this is the fourth line

Now how can I keep only the first two rows and delete only the last two rows?

Note- this is how I read the file from my local machine:
string[] lines = File.ReadAllLines(@"C:\Users\admin\Desktop\COMMANDS.dat");

I have tried something like this but I think it's not so "efficient"

string text = File.ReadAllText(@"C:\Users\admin\Desktop\COMMANDS.dat");
text = text.Replace(lines[2], "");
text = text.Replace(lines[3], ""); 
File.WriteAllText(@"C:\Users\admin\Desktop\COMMANDS.dat", text);

So this actually does the job, it replaces the lines by string with an empty character but when I take a look at the file, I don't want to have 4 lines there, even though 2 of them are real strings and the other two are just empty lines... Can I manage to do this in another way?

CodePudding user response：

Try replacing the newline character with an empty string:

string text = File.ReadAllText(@"C:\Users\admin\Desktop\COMMANDS.dat");
text = text.Replace(lines[2], "").Remove(Environment.NewLine, "");
text = text.Replace(lines[3], "").Remove(Environment.NewLine , "");
File.WriteAllText(@"C:\Users\admin\Desktop\COMMANDS.dat", text);

If my answer is useful, please mark it as accepted, and upvote it.

CodePudding user response：

    async Task Example()
    {
        var inputLines = await File.ReadAllLinesAsync("path/to/file.txt");
        var outputLines = inputLines.Where((l, i) => i < 2);
        await File.WriteAllLinesAsync("target/file.txt", outputLines);
    }

What it does

Read data but not as one string but as a collection of lines
Create a new collection containing only the lines you want in your output
Write the filtered lines

Notes:

This example is not optimized for memory usage (because we read all lines and for larger files, e.g. multiple GB, this will fail). See existing answers for memory optimized version) - but: It's totally fine to do it this way if you know you have just a few k lines. (and it's faster)
Try not to "modify" strings. This will always create a copy and needs a lot of memory.
In this "Linq style" (functional) approach, we should treat data as immutable. That means: we have one variable that represents the input file and one variable that represents the result. We use declarative Linq to describe how the output should look like. "output is input where the filter index < 2 matches" instead of "if xy remove line" in an imperative style.