Increase amount of numbers for picking randomly-CodePudding

There is a batch file that looks for Pen=n in the list.txt and changes its value (n) randomly from the given row of ten numbers (set "var[pen]=1 2 3 4 5 6 7 8 9 10"). But if there are more than ten numbers say twenty (set "var[pen]=1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20") or hundred, it is still picking a number from first ten ones ignoring the rest.

@echo off
setlocal EnableDelayedExpansion

set "file=D:\list.txt"
set "temp=D:\temp.txt"
set "var[pen]=1 2 3 4 5 6 7 8 9 10" &

for /L %%i in (1,10,1%time:~-2%) do set "rand=!random!"

(for /F "usebackq tokens=1,2 delims==" %%a in ("%file%") do (
   if defined var[%%a] (
      call :getRandomValue var="!var[%%a]!"
      echo %%a=!var!
   ) else if "%%b" neq "" (
      echo %%a=%%b
   ) else (
      echo %%a
   )
)) > "%temp%"

move /Y "%temp%" "%file%"

pause > nul && pause > nul
goto :EOF

:getRandomValue value="list"
set /A "rand=!random:~-1! 1"
for /F "tokens=%rand%" %%v in (%2) do set "%1=%%v"

Any help would be appreciated.

edit: the list.txt contains a list of stuff like pen paper rubber etc. with the corresponding value next to it.

pen=5
pencil=43
paper=0
rubber=22

what the bat file does is just putting random number picking in up from the row of numbers provided. in the following case it would change the value of pen to a random number from 1 to 10. but if I add some extra numbers more than ten it will then just ignore them.

CodePudding user response：

What you are aiming to do is to randomly index from a list, which requires you to first determine the number of items in the list.

one method of doing so:

@Echo off

 Set "var[pen]=a b c d e f g h i"

Rem enable enviroment for !expanison!
 Setlocal EnableDelayedExpansion

Rem Build 'array', splitting string on spaces and incrementing array size count
 Set _i=1& Set "item[1]=%var[pen]: =" & Set /A "_i =1" & Set "item[!_i!]=%"

Rem index randomly from known array size [one indexed]
 For /f delims^= %%i in ('Set /A !random! %%!_i!   1')Do Echo(Item:%%i = !Item[%%i]!
 Pause

CodePudding user response：

You forgot to specify the origin post of this problem. In such a post, there is not any specification about how the probabilities must be given, but all the 3 examples provided have 10 probable values, so I assumed that all probabilities have 10 values. The fix is add the number of probabilities each value can have:

@echo off
setlocal EnableDelayedExpansion

rem Define the probabilities for new values
set "value[apple]=0 0 0 0 0 0 0 1 1 1" & set "num[apple]=10" & rem 0 (70%) or 1 (30%)
set "value[peach]=0 0 0 0 0 1 2 3 4 5" & set "num[peach]=10" & rem from 0 (50%) to 5 (the rest 50%)
set "value[banana]=54 68 82 96" & set "num[banana]=4" & rem each 25%

rem Randomize
for /L %%i in (1,10,1%time:~-2%) do set "ran=!random!"

(for /F "tokens=1,2 delims==" %%a in (input.ini) do (
   if defined value[%%a] (
      call :getRandomValue value=%%a
      echo %%a=!value!
   ) else if "%%b" neq "" (
      echo %%a=%%b
   ) else (
      echo %%a
   )
)) > output.ini

move /Y output.ini input.ini
goto :EOF


:getRandomValue value=item
set /A "ran=%random%%%num[%2] 1"
for /F "tokens=%ran%" %%v in ("!value[%2]!") do set "%1=%%v"
exit /B

You also forget (again) to provide the real format of the input file, that include [headers]:

[Berries]
Strawberry=1
Blackberry=-13
Blueberry=100
Cherry=6
[Fruits]
apple=0
peach=4
banana=18
orange=-2.5
[Vegetables]
Potato=44
Tomato=2
Onion=0
Garlic=17