Specific plain English keywords returning specific numerical values using google sheets app script-CodePudding

I'm creating a spreadsheet for developing new cocktails and cocktail ingredients for bars to generate loads of info quickly.

I have made a script based on Anthony Grant's here using switch case to help with calculating the pH of any given solution that picks up the plain English text in the ingredients column that returns the concentration of that substance. For example, the word "Citric" returns the numeric value 192.124 (as that is the molecular weight of citric acid) and so forth depending on the acid. It works great and fits in perfectly. From there I can calculate pH. like this:

/**
 * This function determines the concentration of hydronium ions to be used to calculate pH.
 * To finish the calculation, combine the concentrations of all acids then add into -log10(concentration)
 * @constructor
 * @param {input} amount of acid in grams
 * @param {acid} type of acid in plain English
 * @param {volume} total volume of solution
 * @return The amount of acid divided by the molar mass of acid then divided by the total volume
 * @customfunction
 */

function pHCALC( input, acid, volume) {
  
 var rate = 0 ;
 switch (acid) {
 case 'Citric':
 rate = 192.124;
 break;
 case 'Malic':
 rate = 137.087;
 break;
 case 'Tartaric':
 rate = 150.087;
 break;
 case 'Ascorbic':
 rate = 176.120;
 break;
 case 'Lactic':
 rate = 90.08;
 break;
 case 'Phosphoric':
 rate = 97.994;
 break;
 case 'Acetic':
 rate = 60.052;
 default:
 rate = 0;
 }
 return ((input / rate)/ volume);
}

I was hoping to do the same with the sucrose levels in different syrups, so I just copied the code and changed what I needed to, but for some reason, it doesn't work at all:

/**
 * This function determines sucrose content of common syrups
 * @constructor
 * @param {input} type of sugar/syrup in English
 * @return The amount of sucrose in 1g of noted substance
 * @customfunction
 */

function sugarcalc( input,sugar) {

 var rate = 0;
 switch (sugar) {
 case 'Caster Sugar': rate = 1.0;
 break;
 case 'Honey': rate = 0.82;
 break;
 case '2:1 Honey Syrup': rate = 0.55;
 break;
 case '1:1 Honey Syrup': rate = 0.41;
 break;
 case 'Invert Syrup': rate = 0.70;
 break;
 case '2:1 Sugar Syrup': rate = 0.67;
 break;
 case '3:2 Sugar Syrup': rate = 0.60;
 break;
 case '1:1 Sugar Syrup': rate = 0.50;
 break;
 case 'Agave Syrup': rate = 0.68;
 break;
 case 'Maple Syrup': rate = 0.68;
 break;
 case 'Rice Malt Syrup': rate = 0.55;
 break;
 case 'Gomme': rate = 0.68;
 default:rate = 0;
 }
 return (input * sugar);
}

I want to reference plain English so if the words mentioned in each case get mentioned, then the function will output the correct value depending on the syrup. I get a yellow lightbulb next to "var rate = 0" to begin with, but on the pH function, I don't.

Am I missing something? Thanks in advance

CodePudding user response：

Change the variable to a unique name on your second function. Such as:

var rate2 = 0;

rate has already been defined in the first function.

CodePudding user response：

I think you need to change sugar in this line:

return (input * sugar);

to rate:

return (input * rate);